-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DNM] Execution trace dumping with contract support. #775
Draft
azteca1998
wants to merge
22
commits into
main
Choose a base branch
from
add-trace-dump-contracts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmarking resultsBenchmark for program
|
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
11.185 ± 0.271 | 10.871 | 11.661 | 8.30 ± 0.20 |
cairo-native (embedded AOT) |
3.520 ± 0.049 | 3.479 | 3.624 | 2.61 ± 0.04 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.259 ± 0.033 | 3.216 | 3.320 | 2.42 ± 0.02 |
cairo-native (standalone AOT with -march=native) |
1.348 ± 0.001 | 1.347 | 1.351 | 1.00 |
Benchmark for program fib_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
11.489 ± 0.230 | 10.890 | 11.704 | 146.98 ± 2.97 |
cairo-native (embedded AOT) |
3.090 ± 0.041 | 3.021 | 3.139 | 39.53 ± 0.54 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.959 ± 0.056 | 2.899 | 3.073 | 37.86 ± 0.72 |
cairo-native (standalone AOT with -march=native) |
0.078 ± 0.000 | 0.077 | 0.079 | 1.00 |
Benchmark for program logistic_map
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
4.515 ± 0.067 | 4.413 | 4.598 | 18.60 ± 0.28 |
cairo-native (embedded AOT) |
3.320 ± 0.036 | 3.276 | 3.404 | 13.68 ± 0.15 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.295 ± 0.064 | 3.222 | 3.394 | 13.57 ± 0.26 |
cairo-native (standalone AOT with -march=native) |
0.243 ± 0.000 | 0.242 | 0.244 | 1.00 |
✅ Code is now correctly formatted. |
* Impl ClassHash and SegmentArena * Add trace dump support to compiler * Reset workflows * Update lock * Implement BoundedInt * Fix Enum trace dump * Make gas_metadata public * Update deps * Fix bug * Move deps to optional (trace dump featire)
igaray
changed the title
Execution trace dumping with contract support.
[DNM] Execution trace dumping with contract support.
Sep 12, 2024
Benchmark results Main vs HEAD.
|
* Add logs * Implement Felt252Dict trace dump * Implement nullabel for trace dump * Print type id * Remove print * add convertion for Sints * fix mispelled types * forgot to add feature * change Sints value to correspond to sierra-emu * Readd feature * Add is_infinity field to secp256 point struct (#828) * add is_infinity to secp point * clean * fix * use same deps as blockifier * fix * fix layout * fix test * remove some brittle asserts due to random initial data when adding and muling points at infinity * fix * remove unused dep * fixes, missed the value entry/output * Reset src * Fix warnings * Make library public * Use debug runtime for trace dump * fix storage's values truncations (#839) * fix storage's values truncations * change implementation for i8 i16 i32 i64 too * format * Add ptr check to felt dict entry * Add malloc tracing and fix more memory leaks. (#833) * Add memory tracing. * Partial memory fixes. * Fix arrays. * Simplify dictionaries. Fix false positive memory leak in dictionary drops. * Fix zero-sized allocation. Fix warnings. More mem tracing checks. * Fix mem tracing. * Fix memory leak in `print` libfunc. * Fix array slice libfunc. * Fix starknet memory leaks. * Fix keccak syscall. * Fix dict get double free bug. * Lots of memory fixes. * More fixes. * Fix CI. * Remove old TODOs. * Fix CI (again). * Remove TODOs. * Fix test. * Maybe fix * Maybe fix * Maybe fix * Dont panic when building circuit partial outputs * trace dump for Sha256StateHandler * Builtin costs rework (#837) * Update to 2.8.4, release docs, alpha This PR updates cairo to 2.8.4, adds some release docs and updates the version to alpha.3 to prepare for another release. * try fix * cleanup ci, remove panic in link * rename from jit to from ptr, etc * crates.io badge * progress * progress * fmt2 * progress * progress * fix * fix bench * use struct * Fix felt252 and enum deserialization bugs. (#844) * Fix felt252 and enum deserialization bugs. * Fix formatting. * Also fix the runtime. * Fix errors. * try to fix ci * remove unused deps --------- Co-authored-by: Edgar Luque <[email protected]> * Fix trace dump type conv * fix aot contract executor not passing builtinstats (#849) * Fix felt252 and enum deserialization bugs. * Fix formatting. * Also fix the runtime. * Fix errors. * try to fix ci * remove unused deps * fix aot contract executor not passing builtinstats --------- Co-authored-by: Esteve Soler Arderiu <[email protected]> Co-authored-by: Esteve Soler Arderiu <[email protected]> * Fix bug (#851) * Also fix felt bits in starknet syscall wrappers (#853) * Also fix felt bits in starknet syscall wrappers * style * missed * fix aot contract executor not passing builtinstats (#849) * Fix felt252 and enum deserialization bugs. * Fix formatting. * Also fix the runtime. * Fix errors. * try to fix ci * remove unused deps * fix aot contract executor not passing builtinstats --------- Co-authored-by: Esteve Soler Arderiu <[email protected]> Co-authored-by: Esteve Soler Arderiu <[email protected]> * Fix bug (#851) * Also fix felt bits in starknet syscall wrappers (#853) * Also fix felt bits in starknet syscall wrappers * style * missed * update version to alpha 4 (#854) * bytes31 * Better function attributes and re-enable >O1 opt (#843) * Fix felt252 and enum deserialization bugs. * Fix formatting. * Also fix the runtime. * Fix errors. * try to fix ci * remove unused deps * proper function attributes * add proper function attrs to optimize better, add some passes, run tests with atleast some opts * dont use remi * oops * maybe with opt level 3 now it works * test * works * readd deleted bench * remove dbg * Update bench-hyperfine.sh * fixci * comment * Update src/ffi.rs Co-authored-by: MrAzteca <[email protected]> --------- Co-authored-by: Esteve Soler Arderiu <[email protected]> Co-authored-by: Esteve Soler Arderiu <[email protected]> Co-authored-by: MrAzteca <[email protected]> * Resolve `CAIRO_NATIVE_RUNTIME_LIBRARY` relative path (#841) * feat(ffi): resolve runtime relative path using current dir * chore: remove mentions to old runtime variable * fix: typo --------- Co-authored-by: Bohdan Ohorodnii <[email protected]> * Implement secp * Fix bytes31 * try to fix ci (#858) * update implementing libfuncs doc (#856) * Fix bytes31 bug * Remove unused dep --------- Co-authored-by: FrancoGiachetta <[email protected]> Co-authored-by: Edgar <[email protected]> Co-authored-by: MrAzteca <[email protected]> Co-authored-by: Esteve Soler Arderiu <[email protected]> Co-authored-by: Esteve Soler Arderiu <[email protected]> Co-authored-by: Rodrigo <[email protected]> Co-authored-by: Bohdan Ohorodnii <[email protected]>
…race-dump-contracts
JulianGCalderon
force-pushed
the
add-trace-dump-contracts
branch
from
November 19, 2024 16:45
ae6784e
to
05b9971
Compare
JulianGCalderon
force-pushed
the
add-trace-dump-contracts
branch
from
November 19, 2024 16:47
05b9971
to
7f37246
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #775 +/- ##
=======================================
Coverage 82.89% 82.89%
=======================================
Files 120 120
Lines 34277 34291 +14
=======================================
+ Hits 28414 28427 +13
- Misses 5863 5864 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist