Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wasm with Cairo 1 #1830

Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 33 commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
129c51b
refeactor cairo1-run to use no-std
FrancoGiachetta Aug 29, 2024
2416a96
cairo 1 running with wasm
FrancoGiachetta Aug 30, 2024
dd55d88
update changelog + linting
FrancoGiachetta Aug 30, 2024
fc2bc99
update changelog + linting
FrancoGiachetta Aug 30, 2024
b5f0433
fix lint errors
FrancoGiachetta Aug 30, 2024
49d14cd
compile example test in cairo1 wasm
FrancoGiachetta Aug 30, 2024
22f9787
remove example once finished testing
FrancoGiachetta Aug 30, 2024
71a5805
fix example
FrancoGiachetta Aug 30, 2024
bca85b3
change workflows
FrancoGiachetta Aug 30, 2024
aca5a0a
change workflows
FrancoGiachetta Aug 30, 2024
8ddd66d
make default the cli feature
FrancoGiachetta Aug 30, 2024
5257e47
update readme cairo1-run
FrancoGiachetta Aug 30, 2024
a53878c
fix workflows
FrancoGiachetta Aug 30, 2024
dccb10c
fix workflows
FrancoGiachetta Aug 30, 2024
8780cc6
add workflows to build the wasm example
FrancoGiachetta Sep 2, 2024
439f20d
fix workflow
FrancoGiachetta Sep 2, 2024
3f4ab6f
format workflows as before
FrancoGiachetta Sep 2, 2024
0471e28
add workflow to build cairo_1_wasm_example program
FrancoGiachetta Sep 2, 2024
4a16c73
forgot to install cairo 1 compiler
FrancoGiachetta Sep 2, 2024
6a58670
format
FrancoGiachetta Sep 2, 2024
f455fcc
workflow fix
FrancoGiachetta Sep 2, 2024
7dd993b
add sierra to wasm example
FrancoGiachetta Sep 2, 2024
2fdc435
add sierra to wasm example
FrancoGiachetta Sep 2, 2024
ab04371
fix workflows
FrancoGiachetta Sep 2, 2024
debfed4
format
FrancoGiachetta Sep 2, 2024
85dc2de
fix clippy
FrancoGiachetta Sep 2, 2024
b0e1e6d
fix cairo1-run dependency to std
FrancoGiachetta Sep 2, 2024
bdd20b3
fix cairo1-run dependency to std
FrancoGiachetta Sep 2, 2024
d559aed
fix test command on cairo1-run
FrancoGiachetta Sep 2, 2024
74ecf9f
small typo
FrancoGiachetta Sep 2, 2024
af0f3a4
comments
FrancoGiachetta Sep 2, 2024
567ea7d
format
FrancoGiachetta Sep 2, 2024
4eef4d9
place the comment better
FrancoGiachetta Sep 3, 2024
bb9ac8b
Merge branch 'main' into wasm-cairo1
FrancoGiachetta Sep 4, 2024
d249eb6
make requested changes
FrancoGiachetta Sep 4, 2024
3166484
make requested changes
FrancoGiachetta Sep 5, 2024
5dc92e8
make requested changes
FrancoGiachetta Sep 5, 2024
c7b3856
Merge branch 'main' into wasm-cairo1
FrancoGiachetta Sep 5, 2024
50bd9ee
update workflows
FrancoGiachetta Sep 5, 2024
bd66521
Merge branch 'main' into wasm-cairo1
FrancoGiachetta Oct 1, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -685,7 +685,31 @@ jobs:
cairo-compile cairo_programs/array_sum.cairo --no_debug_info --output cairo_programs/array_sum.json
cd examples/wasm-demo
wasm-pack build --target=web


wasm-demo-cairo1:
name: Build the wasm demo
runs-on: ubuntu-22.04
steps:
- name: Checkout
uses: actions/checkout@v3
with:
fetch-depth: 0

- name: Python3 Build
FrancoGiachetta marked this conversation as resolved.
Show resolved Hide resolved
uses: actions/setup-python@v4
with:
python-version: "3.9"
cache: "pip"

- name: Install cairo-lang and deps
run: |
pip install -r requirements.txt
npm install -g wasm-pack
- name: Build wasm-demo-cairo1
run: |
cd examples/wasm-demo-cairo1
wasm-pack build --target=web

compare-factorial-outputs-all-layouts:
name: Compare factorial outputs for all layouts
needs: [ build-programs, build-release ]
Expand Down Expand Up @@ -763,4 +787,3 @@ jobs:

- name: Run comparison
run: ./vm/src/tests/compare_all_pie_outputs.sh

4 changes: 3 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,13 @@

#### Upcoming Changes

* chore: make cairo 1.0 compatible with wasm [#1830](https://github.com/lambdaclass/cairo-vm/pull/1830)

* chore: bump `cairo-lang-` dependencies to 2.7.1 [#1823](https://github.com/lambdaclass/cairo-vm/pull/1823)

#### [1.0.1] - 2024-08-12

* fix(BREAKING): [#1818](https://github.com/lambdaclass/cairo-vm/pull/1818):
* fix(BREAKING): [#1818](https://github.com/lambdaclass/cairo-vm/pull/1818):
* Fix `MemorySegmentManager::add_zero_segment` function when resizing a segment
* Signature change(BREAKING): `MemorySegmentManager::get_memory_holes` now receives `builtin_segment_indexes: HashSet<usize>`

Expand Down
Loading
Loading