Animation-System Implementation #58
Open
+1,845
−2,567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@darmie I wanted to add you as author/reviewer, but it's not letting me. Perhaps a setting from your end? |
darmie
reviewed
Dec 7, 2024
Comment on lines
+169
to
+173
| /// @details We use a prefix sum encoding of the timestamps, this makes seeking | ||
| /// the entire timeline O(Log2N) as it enables us to use a binary search, | ||
| /// It also allows us to randomly start the animation from any point in the | ||
| /// timeline without modifying the timeline or having to persist the | ||
| /// timeline or the animation state. |
|
All looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements the basic animation system.
Follows up on #54