🧹 remove unused accountMetadata GoCardless API call on sync (actualbu…

…dget#435)
laissonsilveira · Aug 19, 2024 · 8d4dbbf · 8d4dbbf
1 parent b8d2797
commit 8d4dbbf
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 7 deletions.
diff --git a/src/app-gocardless/app-gocardless.js b/src/app-gocardless/app-gocardless.js
@@ -140,7 +140,6 @@ app.post(
 
     try {
       const {
-        iban,
         balances,
         institutionId,
         startingBalance,
@@ -155,7 +154,6 @@ app.post(
       res.send({
         status: 'ok',
         data: {
-          iban: iban ? await sha256String(iban) : null,
           balances,
           institutionId,
           startingBalance,

diff --git a/src/app-gocardless/services/gocardless-service.js b/src/app-gocardless/services/gocardless-service.js
@@ -185,7 +185,7 @@ export const goCardlessService = {
    * @throws {RateLimitError}
    * @throws {UnknownError}
    * @throws {ServiceError}
-   * @returns {Promise<{iban: string, balances: Array<import('../gocardless-node.types.js').Balance>, institutionId: string, transactions: {booked: Array<import('../gocardless-node.types.js').Transaction>, pending: Array<import('../gocardless-node.types.js').Transaction>, all: Array<import('../gocardless.types.js').TransactionWithBookedStatus>}, startingBalance: number}>}
+   * @returns {Promise<{balances: Array<import('../gocardless-node.types.js').Balance>, institutionId: string, transactions: {booked: Array<import('../gocardless-node.types.js').Transaction>, pending: Array<import('../gocardless-node.types.js').Transaction>, all: Array<import('../gocardless.types.js').TransactionWithBookedStatus>}, startingBalance: number}>}
    */
   getTransactionsWithBalance: async (
     requisitionId,
@@ -200,8 +200,7 @@ export const goCardlessService = {
       throw new AccountNotLinedToRequisition(accountId, requisitionId);
     }
 
-    const [accountMetadata, transactions, accountBalance] = await Promise.all([
-      goCardlessService.getAccountMetadata(accountId),
+    const [transactions, accountBalance] = await Promise.all([
       goCardlessService.getTransactions({
         institutionId: institution_id,
         accountId,
@@ -232,7 +231,6 @@ export const goCardlessService = {
     );
 
     return {
-      iban: accountMetadata.iban,
       balances: accountBalance.balances,
       institutionId: institution_id,
       startingBalance,

diff --git a/src/app-gocardless/services/tests/gocardless-service.spec.js b/src/app-gocardless/services/tests/gocardless-service.spec.js
@@ -168,7 +168,6 @@ describe('goCardlessService', () => {
         ),
       ).toEqual(
         expect.objectContaining({
-          iban: mockAccountMetaData.iban,
           balances: mockedBalances.balances,
           institutionId: mockRequisition.institution_id,
           startingBalance: expect.any(Number),

diff --git a/upcoming-release-notes/435.md b/upcoming-release-notes/435.md
@@ -0,0 +1,6 @@
+---
+category: Maintenance
+authors: [matt-fidd]
+---
+
+Optimise GoCardless sync to reduce API usage by removing accountMetadata call