Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canaries #54

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Canaries #54

wants to merge 2 commits into from

Conversation

supermeng
Copy link
Member

Fix #53

@ghost ghost assigned supermeng Mar 9, 2018
@ghost ghost added the needs review label Mar 9, 2018
@codecov
Copy link

codecov bot commented Mar 9, 2018

Codecov Report

Merging #54 into master will decrease coverage by 0.91%.
The diff coverage is 63.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
- Coverage   49.44%   48.52%   -0.92%     
==========================================
  Files          20       21       +1     
  Lines        3578     3703     +125     
==========================================
+ Hits         1769     1797      +28     
- Misses       1627     1714      +87     
- Partials      182      192      +10
Impacted Files Coverage Δ
engine/specs.go 53.19% <ø> (-1.84%) ⬇️
engine/runtimes.go 31.25% <ø> (-1.17%) ⬇️
engine/config.go 31.57% <ø> (ø) ⬆️
engine/canaries.go 40.62% <40.62%> (ø)
engine/podgroup.go 48.08% <44.44%> (-1.2%) ⬇️
engine/engine.go 43.33% <56%> (+0.61%) ⬆️
engine/podgroup_ops.go 42.22% <83.33%> (-7.27%) ⬇️
engine/pod.go 61.69% <85%> (+1.2%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f0b190...9c3a492. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant