-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/tutorials2 #246
base: master
Are you sure you want to change the base?
Feat/tutorials2 #246
Conversation
I would like to discuss this also in the meeting. I'll put it in the minutes. Quickly here:
You list Other remarks to thinkg about: |
For clarity I would mention GAP users rather than QUIP users since the QUIP package does many other things. |
And to be fair, quite a bit of the audience we're writing these for will be GAP users who will want to switch for the speed boost (and modern SOAP features). Of course we're planning on having two tracks for SOAP/SO(3) and ClusterExpansion uses; this is mainly just starting with what we know. |
I am not saying you intentionally omitted it. Just trying to provide feedback from my perspective. Maybe we could make that section something like: Transition from other libraries
Another thing to maybe keep in mind: are we in competition to DScribe and should we add transition tutorials for that? Just to summarize a little for the discussion tomorrow: |
This is a draft PR to provide a pipeline for adding the tutorials to master. The rebase became unwieldy, so @Luthaf suggested a new branch from master with only the existing files. Currently the tutorials are as follows (all within the docs/source/tutorials folder):
notebooks listed in bold are in progress or completed, those listed in italics are empty as of opening this PR
Envisioned tutorial flows are (as defined in index.rst):
For new users:
For users coming from QUIP:
For developers:
Other existing examples/tutorials, which can be worked into documentation:
Intended Purpose of this PR
Tasks before review:
formatted correctly (ask @max-veit if you need help with this task).
explain the feature and its usage in plain English
to verify the fix and catch future regressions as well as similar bugs
elsewhere in the code.
make lint
on the project, ensure it passesmake pretty-cpp
andmake pretty-python
, check that theauto-formatting is sensible
own branch
nbstripout