-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read the Write Key #44
base: master
Are you sure you want to change the base?
Conversation
@LeonardoRosaa what's the purpose of this write key? I want to have more context to understand the value of the implementation |
I felt that is unnecessary that the client needs to do their logic to get the Android or IOS write key. This PR implements that the own package solves the logic to load the right key. |
@LeonardoRosaa thanks for the answer, I was asking about the write key related to segment, I dont have context about the purpose of this, excuse for that |
The write key is required to send data to the Segment Platform. |
@danielgomezrico to make it more clear, currently users have to do something like this: Segment.config(
options: SegmentConfig(
writeKey: Platform.isAndroid ? ANDROID_WRITE_KEY : IOS_WRITE_KEY,
trackApplicationLifecycleEvents: true,
)); @LeonardoRosaa moved the logic to decide which write key to use in the package, so when initializing |
Sorry for the delay I was thinking that not every project has iOS and android at the same time, we are currently working on a project that started as android only. So, I'm thinking that this use case may break for some people, and so we should not move into that direction? 🤔 |
Does make sense to start the package on a platform that will not use the package? |
Sorry, I don't get your question, we are using it, but currently we have only android (on our project), can you reword your question please? |
The most applications to Flutter have support for IOS and Android therefore it does make sense to keep the loading WRITE_KEY within the package.