Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

com.google.android.play:core:1.10.0 issues #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

BenLaKnet
Copy link

When publishing a new version of app, we have an issue from Google like:

com.google.android.play:core has added this note for core:1.10.0:

Update your Play Core Maven dependency to an Android 14 compatible version! Your current Play Core library is incompatible with targetSdkVersion 34 (Android 14), which introduces a backwards-incompatible change to broadcast receivers to improve user security. As a reminder, from August 31, Google Play requires all new app releases to target Android 14. Update to the latest Play Core library version dependency to avoid app crashes: https://developer.android.com/guide/playcore#playcore-migration

Upgrade build gradle to delete play:core references
Update for play:core references
@afeurra
Copy link

afeurra commented Jul 24, 2024

Hey thanks for this PR, I'm trying to make it work.
Seems like there's still something odd cause in com.google.android.play:core:1.10.3 AppUpdateManager still uses com.google.android.play.core.tasks.Task. Am I doing something wrong?

/Users/andrea/Desktop/Projects/HUB/TCS-Hub-frontend/platforms/android/app/src/main/java/com/apache/cordova/appupdate/CDVAppUpdate.java:178: error: incompatible types: com.google.android.play.core.tasks.Task<AppUpdateInfo> cannot be converted to com.google.android.gms.tasks.Task<AppUpdateInfo>
        Task<AppUpdateInfo> appUpdateInfoTask = appUpdateManager.getAppUpdateInfo();
                                                                                 ^

@BenLaKnet
Copy link
Author

Hi @afeurra,
Have you changde only this 2 files or others ?

I just changed this twos file and all is running for me.

@afeurra
Copy link

afeurra commented Jul 25, 2024

Hi! I finally managed to make this work. I have a lot of other plugins that are not fully maintained (I know I should fix this...). I just needed to roll back to

        sourceCompatibility JavaVersion.VERSION_1_8
        targetCompatibility JavaVersion.VERSION_1_8

Plugin's working great now! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants