Added sliding_similarities module with continuous jaccard #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AvantiShri
reviewed
Sep 25, 2018
|
(If so, can you also bump the version number?) |
|
Will add a small test tomorrow for continuous jaccard (comparing it to your existing non-sliding implementation) and then it's good to go . It worked in the notebook |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should have only one module for computing the similarity metrics which all of the downstream methods should use. I hence created a new module called
sliding_similarities. This could also be renamed tosimilarity_metricsand it could then contain all the metrics including the normal non-sliding similarity metrics.