manifest envsubst

[so-jelly]

What this PR does / why we need it:

This PR replaces variable references in manifests with environment variables. It also adds the generated pet name to the environment so that it can be templated as well.

Fixes # #203

[kensipe]

I'll take a deeper look later today... however I would move out of test/utils. It was there prior to my getting involved but have always disliked it. We don't use "utils" in Go generally. the package name provides meaning and context to the use of a func or struct. Could we please consider moving it to a more meaningful package?

We are not going to introduce a need copyright into our code base tho... so translate.go needs to change to a deps or be written.

[kensipe]

Thanks for the contribution... We need a sign-off on the DCO to move forward

[gberche-orange]

thanks @so-jelly for this contrib! It would very much helm me with asserting cluster-wide resources dynamically instanciated by a kuttl and referencing the associated $NAMESPACE.

Any chance for you to proceed with the DCO signature so that this feature can be merged,, such as running git rebase --signoff HEAD~2 ?

[haarchri]

@so-jelly can you rebase and add DCO - happy to see this change comes in ;)

[so-jelly]

I refactored to remove that licensed code. Some edge cases i considered is variables in GVK and keys. I have thought through this a bit and I think it is sound. I can add some test cases as well.

[so-jelly]

I created test cases for some additional field entries. I am not sure what is up with Github review requests. tagging @kensipe in case the review request isn't sufficient.

[jaypipes]

We need this basically yesterday :) Any chance we can see this merged?

[kensipe]

@jaypipes I can provide details elsewhere... I'm just seeing this. looks urgent and apologies for being out of pocket... for way too long. I will review today/night and respond and/or merge

[dooman87]

Wonder if this is something that could be added.

Our use case is we need a random string in the resource manifest so external resources are not clashing when running.

[porridge]

@dooman87 there is #387 that I have higher hopes for... but not enough time to work on it further at the moment.

As for random strings, have you investigated generateName (docs)?

[dooman87]

Thanks @porridge, #387 looks promising!

I looked into generateName but could you use it for any field? I have something like:

apiVersion: ourcrd/v1beta1
kind: CustomObject
metadata:
  name: test-object
spec:
  path: /path/to/s3/need-random-value-here/

Because every test is running it its own namespace having the same name is fine, but we need different path for every test run.

I workarounded it by generating manifest and using envsubst but it does look hacky :)

[porridge]

No @dooman87 , it's specific to metadata.name I think.

Believe me, I know the pain of envsubst 😅

[porridge]

Perhaps https://github.com/kyverno/chainsaw would be an option for you @dooman87 ?