Also check negative cases

kubukoz · Oct 3, 2023 · 1b205d3 · 1b205d3
1 parent b35bbf7
commit 1b205d3
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/modules/parser/src/test/scala/playground/smithyql/parser/ParserSuite.scala b/modules/parser/src/test/scala/playground/smithyql/parser/ParserSuite.scala
@@ -55,6 +55,13 @@ trait ParserSuite extends SimpleIOSuite {
       }
     }
 
+    validTokensTest(testCase, trimWhitespace)
+  }
+
+  private def validTokensTest(
+    testCase: TestCase,
+    trimWhitespace: Boolean,
+  ) =
     test(testCase.name + " (v2 scanner)") {
       testCase.readInput(trimWhitespace).map { input =>
         val scanned = Scanner.scan(input)
@@ -65,11 +72,12 @@ trait ParserSuite extends SimpleIOSuite {
         assert(errors.isEmpty)
       }
     }
-  }
 
+  // invalidTokens: a flag that tells the suite whether the file should contain invalid tokens.
   def loadNegativeParserTests[Alg[_[_]]: SourceParser](
     prefix: String,
     trimWhitespace: Boolean = false,
+    invalidTokens: Boolean,
   ): Unit = loadTestCases("", List("negative", prefix)).foreach { testCase =>
     test(testCase.name) {
       testCase.readInput(trimWhitespace).map { input =>
@@ -79,6 +87,10 @@ trait ParserSuite extends SimpleIOSuite {
         }
       }
     }
+
+    if (!invalidTokens)
+      validTokensTest(testCase, trimWhitespace)
+
   }
 
   private def readText(

diff --git a/...est/scala/playground/smithyql/parser/generative/negative/PreludeParserNegativeTests.scala b/...est/scala/playground/smithyql/parser/generative/negative/PreludeParserNegativeTests.scala
@@ -4,5 +4,5 @@ import playground.smithyql.Prelude
 import playground.smithyql.parser.ParserSuite
 
 object PreludeParserNegativeTests extends ParserSuite {
-  loadNegativeParserTests[Prelude]("prelude", trimWhitespace = true)
+  loadNegativeParserTests[Prelude]("prelude", trimWhitespace = true, invalidTokens = false)
 }