Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable testing #41

Merged
merged 1 commit into from
Nov 13, 2023
Merged

enable testing #41

merged 1 commit into from
Nov 13, 2023

Conversation

flavio
Copy link
Member

@flavio flavio commented Nov 13, 2023

Render the template and make sure the demo policy works.

WARNING: this PR fails because our template policy currently doesn't compile. I propose to fix the compilation issue with another PR

Some additional notes:

GH actions used to be disabled on this repo because the templating of the files like Cargo.toml cause the usual checks to fail.

This PR introduces a new action that takes care of rendering the repository and running some sanity checks against it.
The new GH action is ignored by cargo-generate, meaning our downstream users will NOT get it.

In the meantime I've also enabled the GH actions support for this repo (so that the new action could run). I disabled manually the test and the release.

They have to stay disabled because

  • the test one: it cannot run because of the templating, but this is now covered by the new action the PR introduces
  • the release action: we don't want to release this policy at all

I didn't want to rename these actions, because otherwise dependabot would not have updated them.

@flavio flavio requested a review from a team as a code owner November 13, 2023 10:27
Render the template and make sure the demo policy works.

Signed-off-by: Flavio Castelli <[email protected]>
@flavio flavio added the kind/enhancement New feature or request label Nov 13, 2023
@flavio flavio self-assigned this Nov 13, 2023
Copy link
Member

@viccuad viccuad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Many thanks for this!

@flavio flavio merged commit acf24aa into kubewarden:main Nov 13, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants