-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use go vendoring for dependencies #3522
use go vendoring for dependencies #3522
Conversation
/cc @xpivarc FYI: since kubernetes-sigs/test-infra and kubernetes-sigs/prow moved away from using bazel, maintaining it has become more of a burden - so we think it's best to remove it and work with go tools only. |
fe2cbe6
to
343c83c
Compare
/test pull-project-infra-test-robots |
343c83c
to
588fdee
Compare
/rehearse ? |
Rehearsal is available for the following jobs in this PR:
You can trigger rehearsal for all jobs by commenting either For a specific PR you can comment For a list of jobs that you can rehearse you can comment |
/rehearse pull-project-infra-test-robots |
Rehearsal jobs created for this PR:
You can trigger rehearsal for all jobs by commenting either For a specific PR you can comment For a list of jobs that you can rehearse you can comment |
/test pull-project-infra-test-robots |
I like vendoring 👍 |
588fdee
to
5e7a333
Compare
/rehearse |
Rehearsal jobs created for this PR:
You can trigger rehearsal for all jobs by commenting either For a specific PR you can comment For a list of jobs that you can rehearse you can comment |
/rehearse pull-project-infra-test-robots |
Rehearsal jobs created for this PR:
You can trigger rehearsal for all jobs by commenting either For a specific PR you can comment For a list of jobs that you can rehearse you can comment |
/test pull-project-infra-test-robots |
/test pull-project-infra-test-bazel-config |
5e7a333
to
fe2e392
Compare
/rehearse pull-project-infra-test-bazel-config |
Rehearsal jobs created for this PR:
You can trigger rehearsal for all jobs by commenting either For a specific PR you can comment For a list of jobs that you can rehearse you can comment |
/test all |
fe2e392
to
e1c0f98
Compare
/test all |
b9a22b1
to
6e31992
Compare
/test pull-project-infra-test-bazel-config |
/test pull-project-infra-ci-search-deploy-test |
6e31992
to
8f32eaf
Compare
/test pull-project-infra-test-bazel-config |
/test pull-project-infra-test-external-plugins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @dhiller - could you just add some more context on why we want to do this to the PR description?
@@ -43,7 +43,7 @@ gazelle: | |||
$(bazelbin) run //:gazelle | |||
|
|||
gazelle-update-repos: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this be removed in a follow up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, currently there's lane failure if you remove it. Therefore I just emptied it.
Remove gazelle-update-repos make target as no longer required on the way. Signed-off-by: Daniel Hiller <[email protected]>
8f32eaf
to
eeccf69
Compare
@dhiller: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@brianmcarey updated PR description, PTAL, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
thanks @dhiller! it will be good to able to consume prow updates again.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brianmcarey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dhiller: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Replaces the bazel dependency management for go repositories with pure go mod vendoring. This is required because kubernetes-sigs/prow has dropped bazel a while ago - since then we haven't been able to update the prow dependencies. This way we should be able to consume prow dependency updates again.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
/cc @brianmcarey
Jira-ticket: https://issues.redhat.com/browse/CNV-49006