Skip to content

Commit

Permalink
cluster: Allow overriding kubevirtci params
Browse files Browse the repository at this point in the history
When running tests from other repos, the cluster that was created
should be the one vendored, so the scripts will match.
Otherwise it can cause errors (for example via CNAO).

Set KUBEVIRTCI_TAG and KUBEVIRT_PROVIDER only if not set yet.

It also allows overriding locally upon needs.

Signed-off-by: Or Shoval <[email protected]>
  • Loading branch information
oshoval committed Sep 26, 2024
1 parent 72f718e commit 833efc9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion automation/check-patch.e2e-k8s.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ teardown() {
}

main() {
export KUBEVIRT_PROVIDER='k8s-1.28'
export KUBEVIRT_PROVIDER=${KUBEVIRT_PROVIDER:-k8s-1.28}

source automation/check-patch.setup.sh
cd ${TMP_PROJECT_PATH}
Expand Down
4 changes: 2 additions & 2 deletions cluster/cluster.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/usr/bin/env bash

export KUBEVIRT_PROVIDER="${KUBEVIRT_PROVIDER:-k8s-1.28}"
export KUBEVIRTCI_TAG=2408151028-a0ad3359
export KUBEVIRT_PROVIDER=${KUBEVIRT_PROVIDER:-k8s-1.28}
export KUBEVIRTCI_TAG=${KUBEVIRTCI_TAG:-2408151028-a0ad3359}
export KUBEVIRTCI_RUNTIME=${OCI_BIN:-docker}

KUBEVIRTCI_REPO='https://github.com/kubevirt/kubevirtci.git'
Expand Down

0 comments on commit 833efc9

Please sign in to comment.