Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: Fix wrong base image arch when cross-building with podman #78

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

jschintag
Copy link
Contributor

@jschintag jschintag commented Dec 6, 2024

When cross-building the image for s390x on amd64, podman would use an amd64 image for the base of the final image.

What this PR does / why we need it:
Fix cross-building manually on amd64 with podman.

What works now:

On x86_64 host:

  • docker amd64 build
  • podman amd64 build
  • docker s390x build
  • podman s390x build (fixed by this PR)

On s390x host:

  • podman s390x build

Special notes for your reviewer:

When cross-building the image for s390x on amd64, podman would use an amd64
image for the base of the final image.

Signed-off-by: Jan Schintag <[email protected]>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Dec 6, 2024
@jschintag
Copy link
Contributor Author

jschintag commented Dec 6, 2024

With this we have the following for working and tested by me build ways:

On x86_64 host:

  • docker amd64 build
  • podman amd64 build
  • docker s390x build
  • podman s390x build (fixed by this PR)

On s390x host:

  • podman s390x build

Since docker does not currently offer builds for s390x on their fedora mirror, i haven't tested it.

@oshoval
Copy link
Collaborator

oshoval commented Dec 8, 2024

Great, thanks

/lgtm
/approve

Nit:
in the above comment, i think you meant on the 4th bullet
"podman, host amd64, target s390x (fixed by this PR)"

best to add the sum of all what is supported and what isn't to the PR desc please

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oshoval

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2024
@kubevirt-bot kubevirt-bot merged commit 48b7ba5 into kubevirt:main Dec 8, 2024
9 of 10 checks passed
@jschintag jschintag deleted the cross-build-podman branch December 9, 2024 09:32
@jschintag
Copy link
Contributor Author

Nit: in the above comment, i think you meant on the 4th bullet "podman, host amd64, target s390x (fixed by this PR)"

best to add the sum of all what is supported and what isn't to the PR desc please

I had them grouped by host, but the formating made it not look that way... I fixed it and copied it to the PR description as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants