Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the GitHub runner image to Ubuntu 22.04 explicitly. #80

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

ashokpariya0
Copy link
Contributor

ubuntu-latest now uses Ubuntu 24.04, while it used to use 22.04. To unblock Github CI in the short term, we set it to ubuntu-22.04.

What this PR does / why we need it:
It has been observed that build actions, such as free disk space, are broken
with ubuntu-latest, which now points to Ubuntu 24.04. To resolve this,
we are switching to the ubuntu-22.04 tag, which was previously used by ubuntu-latest.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:
Please check error logs on PR: #78
please check issue: actions/runner-images#10636

Release note:

None

ubuntu-latest now uses Ubuntu 24.04, while it used to use 22.04.
To unblock Github CI in the short term, we set it to ubuntu-22.04.

Signed-off-by: Ashok Pariya <[email protected]>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Dec 16, 2024
@ashokpariya0
Copy link
Contributor Author

cc @oshoval

@oshoval
Copy link
Collaborator

oshoval commented Dec 16, 2024

Thanks

/lgtm

/cc @maiqueb

@kubevirt-bot kubevirt-bot requested a review from maiqueb December 16, 2024 10:30
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2024
Copy link
Collaborator

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maiqueb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2024
@kubevirt-bot kubevirt-bot merged commit edd2f8f into kubevirt:main Dec 16, 2024
4 checks passed
@oshoval
Copy link
Collaborator

oshoval commented Dec 17, 2024

Thanks
ovn-kubernetes/ovn-kubernetes#4920 this is the proper fix once one of us can do it please
on ipam/cnao
best to be aligned with OVN

@ashokpariya0
Copy link
Contributor Author

Thanks ovn-kubernetes/ovn-kubernetes#4920 this is the proper fix once one of us can do it please on ipam/cnao best to be aligned with OVN

Okay, noted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants