Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Fix artifacts collecting #66

Merged
merged 1 commit into from
Sep 9, 2024
Merged

e2e: Fix artifacts collecting #66

merged 1 commit into from
Sep 9, 2024

Conversation

oshoval
Copy link
Collaborator

@oshoval oshoval commented Sep 8, 2024

What this PR does / why we need it:
Due to actions/upload-artifact#602
Hidden folders are skipped.
We are using .output, so it was skipped and artifacts were not collected in case of an error.
Rename it to fix the problem.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:


@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 8, 2024
@oshoval oshoval changed the title e2e: Fix artifacts collecting WIP e2e: Fix artifacts collecting Sep 8, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign maiqueb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Due to actions/upload-artifact#602
Hidden folders are skipped.
We are using .output, so it was skipped and artifacts were not collected in case of an error.
Rename it to fix the problem.

Signed-off-by: Or Shoval <[email protected]>
@oshoval oshoval changed the title WIP e2e: Fix artifacts collecting e2e: Fix artifacts collecting Sep 8, 2024
@oshoval oshoval marked this pull request as ready for review September 8, 2024 15:19
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 8, 2024
@oshoval
Copy link
Collaborator Author

oshoval commented Sep 8, 2024

@maiqueb @qinqon
can you review please ?
it worked once i tried to inject an err
https://github.com/kubevirt/ipam-extensions/actions/runs/10760835111

@qinqon qinqon merged commit 74c7ef7 into kubevirt:main Sep 9, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants