Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

udn: rename the annotation used #64

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

maiqueb
Copy link
Collaborator

@maiqueb maiqueb commented Sep 6, 2024

What this PR does / why we need it:
This PR renames the annotation used to match the annotation expected in this OVN-Kubernetes PR.

In the future, we may actually use a label, and this name might change.

We expect to define this in this OpenShift enhancement.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:


@maiqueb maiqueb requested a review from qinqon September 6, 2024 15:39
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Sep 6, 2024
@kubevirt-bot kubevirt-bot requested a review from oshoval September 6, 2024 15:39
Copy link
Collaborator

@qinqon qinqon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix tests

pkg/config/types.go Show resolved Hide resolved
Signed-off-by: Miguel Duarte Barroso <[email protected]>
@maiqueb maiqueb force-pushed the rename-udn-annotation branch from 01a6040 to 7b53fe1 Compare September 6, 2024 15:48
@qinqon
Copy link
Collaborator

qinqon commented Sep 6, 2024

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2024
@kubevirt-bot kubevirt-bot merged commit bd56064 into kubevirt:main Sep 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants