[WIP] MTV-1699 Avoid potentially exceeding memory limit in multi-stage VDDK imports. #3559
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
From this conversation, this pull request avoids storing all results from QueryChangedDiskAreas during a VDDK warm migration. A disk with a lot of small evenly-spaced changes could get the importer to create a huge list, which might exceed the pod's memory limit. This change iterates over one result from QueryChangedDiskAreas at a time, which so far seems to be limited to 2000 changed extent entries.
Which issue(s) this PR fixes:
Fixes MTV-1699
Special notes for your reviewer:
This is a draft for now while I get this tested more thoroughly.
Release note: