Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webhooks/datavolume: comment about remove check of claim adoption #3481

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

ShellyKa13
Copy link
Contributor

There is an open issue in github to remove the claim adoption feature gate:
#3480 Once the FG is removed we should remove the check in the webhook that verifies if it allowed to have an existing PVC.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

There is an open issue in github to remove the claim
adoption feature gate:
kubevirt#3480
Once the FG is removed we should remove the check in the webhook
that verifies if it allowed to have an existing PVC.

Signed-off-by: Shelly Kagan <[email protected]>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 28, 2024
@coveralls
Copy link

Coverage Status

coverage: 59.297% (+0.03%) from 59.267%
when pulling 0da05aa on ShellyKa13:comment-dv-webhook
into 75f00e2 on kubevirt:main.

@alromeros
Copy link
Collaborator

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2024
@awels
Copy link
Member

awels commented Oct 28, 2024

/approve
/override pull-containerized-data-importer-non-csi-hpp

@kubevirt-bot
Copy link
Contributor

@awels: Overrode contexts on behalf of awels: pull-containerized-data-importer-non-csi-hpp

In response to this:

/approve
/override pull-containerized-data-importer-non-csi-hpp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2024
@kubevirt-bot kubevirt-bot merged commit 495b44a into kubevirt:main Oct 28, 2024
20 checks passed
universal-itengineer pushed a commit to deckhouse/3p-containerized-data-importer that referenced this pull request Oct 29, 2024
…bevirt#3481)

There is an open issue in github to remove the claim
adoption feature gate:
kubevirt#3480
Once the FG is removed we should remove the check in the webhook
that verifies if it allowed to have an existing PVC.

Signed-off-by: Shelly Kagan <[email protected]>
universal-itengineer pushed a commit to deckhouse/3p-containerized-data-importer that referenced this pull request Oct 29, 2024
…bevirt#3481)

There is an open issue in github to remove the claim
adoption feature gate:
kubevirt#3480
Once the FG is removed we should remove the check in the webhook
that verifies if it allowed to have an existing PVC.

Signed-off-by: Shelly Kagan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants