Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set PLATFORMS to "all" for multi-platform image support in release pr… #1956

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

ashokpariya0
Copy link
Contributor

…ocess

Added export of PLATFORMS=all to automation/release.sh to ensure the build supports multiple platforms.

What this PR does / why we need it:
The CNAO post-submit Prow job, defined [here](https://github.com/kubevirt/project-infra/blob/d274a82bc8f88e6c5c4c35de60de9b357b34268d/github/ci/prow-deploy/files/jobs/kubevirt/cluster-network-addons-operator/cluster-network-addons-operator-postsubmits.yaml#L25), uses ./automation/release.sh to build and post CNAO release images. By default, it posts an image for the amd64 architecture (based on the host system). To enable building of multi-platform images, the PLATFORMS=all variable is added, allowing the creation of images for additional architectures like arm64, s390x, and others.

Special notes for your reviewer:
Build instruction is available at: https://gist.github.com/ashokpariya0/19b6f235a3fe149d16d82d92c84ce542/edit

Release note:

None

…ocess

Added export of PLATFORMS=all to automation/release.sh to ensure
the build supports multiple platforms.

Signed-off-by: Ashok Pariya <[email protected]>
@kubevirt-bot kubevirt-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 18, 2024
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Dec 18, 2024
@kubevirt-bot
Copy link
Collaborator

Hi @ashokpariya0. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@RamLavi
Copy link
Collaborator

RamLavi commented Dec 19, 2024

/ok-to-test

@oshoval
Copy link
Collaborator

oshoval commented Dec 22, 2024

Thanks
/test all

ok-to-test is gone i think

@oshoval
Copy link
Collaborator

oshoval commented Dec 22, 2024

/hold
until @maiqueb gives green light so we wont merge by mistake stuff
(first need to finish passt removal effort iiuc)

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 22, 2024
@oshoval
Copy link
Collaborator

oshoval commented Dec 23, 2024

Thanks
Nits:
Please use new lines on PR desc
Please fix the wrapping of the title, so it wont reach the PR desc

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 23, 2024
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oshoval

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2024
@oshoval
Copy link
Collaborator

oshoval commented Dec 23, 2024

@maiqueb
we can unhold this one imo, because it will only affect when a new release is created by creating multi arch,
nothing more should happen
wdyt?

EDIT - since Ashok is going to vacation, lets wait, because if any problems arise we would need assist

@oshoval
Copy link
Collaborator

oshoval commented Dec 24, 2024

Note, there is a new branch now, so iiuc we can unhold
as the danger is gone

@oshoval
Copy link
Collaborator

oshoval commented Dec 24, 2024

/hold cancel
Thanks

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 24, 2024
@oshoval
Copy link
Collaborator

oshoval commented Dec 24, 2024

About a release for CNAO main, lets do it only after we finish with all components wrt to multi arch

@kubevirt-bot kubevirt-bot merged commit 2343f28 into kubevirt:main Dec 24, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants