-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set PLATFORMS to "all" for multi-platform image support in release pr… #1956
Conversation
…ocess Added export of PLATFORMS=all to automation/release.sh to ensure the build supports multiple platforms. Signed-off-by: Ashok Pariya <[email protected]>
Hi @ashokpariya0. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Quality Gate passedIssues Measures |
/ok-to-test |
Thanks ok-to-test is gone i think |
/hold |
Thanks /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oshoval The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@maiqueb EDIT - since Ashok is going to vacation, lets wait, because if any problems arise we would need assist |
Note, there is a new branch now, so iiuc we can unhold |
/hold cancel |
About a release for CNAO main, lets do it only after we finish with all components wrt to multi arch |
…ocess
Added export of PLATFORMS=all to automation/release.sh to ensure the build supports multiple platforms.
What this PR does / why we need it:
The CNAO post-submit Prow job, defined [here](https://github.com/kubevirt/project-infra/blob/d274a82bc8f88e6c5c4c35de60de9b357b34268d/github/ci/prow-deploy/files/jobs/kubevirt/cluster-network-addons-operator/cluster-network-addons-operator-postsubmits.yaml#L25), uses
./automation/release.sh
to build and post CNAO release images. By default, it posts an image for the amd64 architecture (based on the host system). To enable building of multi-platform images, thePLATFORMS=all
variable is added, allowing the creation of images for additional architectures like arm64, s390x, and others.Special notes for your reviewer:
Build instruction is available at: https://gist.github.com/ashokpariya0/19b6f235a3fe149d16d82d92c84ce542/edit
Release note: