Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP check main branch state #1944

Closed
wants to merge 1 commit into from
Closed

WIP check main branch state #1944

wants to merge 1 commit into from

Conversation

oshoval
Copy link
Collaborator

@oshoval oshoval commented Dec 15, 2024

What this PR does / why we need it:

Special notes for your reviewer:

Release note:


@kubevirt-bot
Copy link
Collaborator

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 15, 2024
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oshoval
Copy link
Collaborator Author

oshoval commented Dec 15, 2024

@RamLavi
KMP is broken on clean main can you please take a look ?
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_cluster-network-addons-operator/1944/pull-cluster-network-addons-operator-unit-test/1868306825892335616

cc @ashokpariya0

@oshoval
Copy link
Collaborator Author

oshoval commented Dec 15, 2024

all the other lanes fails also due to that it seems

@RamLavi
Copy link
Collaborator

RamLavi commented Dec 16, 2024

should work now
/retest

@ashokpariya0
Copy link
Contributor

should work now /retest

No, It will not work, we need to merge this pr: #1945

@oshoval
Copy link
Collaborator Author

oshoval commented Dec 16, 2024

rest of the lanes might, just not ipam
step by step ;]

@oshoval
Copy link
Collaborator Author

oshoval commented Dec 16, 2024

first time i see this error seems it affect now (assuming this is the root error)

error applying manifest configmaps "grafana-dashboard-prometheus" already exists
maybe need to bump kubevirtci ? not sure what was changed
maybe there is somehow double deploy of that now

@ashokpariya0
Copy link
Contributor

for multus func tests are also failing with below error:

/tmp/cnao//cluster-network-addons-operator/cluster/kubectl.sh apply -f -
selecting podman as container runtime
nmstate.nmstate.io/nmstate created

  • sleep 30
  • /tmp/cnao//cluster-network-addons-operator/cluster/kubectl.sh rollout status -w -n nmstate ds nmstate-handler
    selecting podman as container runtime
    Error from server (NotFound): daemonsets.apps "nmstate-handler" not found
  • teardown
  • rm -rf /tmp/deploy.multus.Xe5a/github.com/k8snetworkplumbingwg/multus-cni
  • cd /tmp/cnao//cluster-network-addons-operator
  • make cluster-down

@oshoval
Copy link
Collaborator Author

oshoval commented Dec 16, 2024

/test pull-e2e-cluster-network-addons-operator-multus-functests
lets see if it is gone, worth to try and update nmstate
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_cluster-network-addons-operator/1944/pull-e2e-cluster-network-addons-operator-multus-functests/1868575389849227264

@oshoval
Copy link
Collaborator Author

oshoval commented Dec 16, 2024

/retest
lets give another chance for the others as some passed

@oshoval
Copy link
Collaborator Author

oshoval commented Dec 16, 2024

merged ipam fix
thanks
#1945

@oshoval
Copy link
Collaborator Author

oshoval commented Dec 16, 2024

ah need to rebase for git actions
will try soon, waiting to see the other lanes first

EDIT once they pass we can close this sanity check PR
and continue on the real ones

@oshoval
Copy link
Collaborator Author

oshoval commented Dec 16, 2024

kmp related passed
thx

@oshoval oshoval closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants