Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable s390x prometheus check #1920

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

nestoracunablanco
Copy link
Contributor

As of version 2.15.2, there is no available container image for s390x. However, version 2.25.2 does provide support for this architecture. This update enables the checks to run on s390x.

What this PR does / why we need it: s390x enablement

Special notes for your reviewer:

Release note:


As of version 2.15.2, there is no available container image for
s390x. However, version 2.25.2 does provide support for this
architecture. This update enables the checks to run on s390x.

Signed-off-by: Nestor Acuna Blanco <[email protected]>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 14, 2024
@kubevirt-bot
Copy link
Collaborator

Hi @nestoracunablanco. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

@oshoval
Copy link
Collaborator

oshoval commented Oct 14, 2024

Thanks
Maybe worth to add it to kubevirtci (if it is used there ?, otherwise fine here)

but we can just continue the current flow as is, and do what you suggested
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2024
@oshoval
Copy link
Collaborator

oshoval commented Oct 14, 2024

/test all

@RamLavi
Copy link
Collaborator

RamLavi commented Oct 14, 2024

/approve

@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2024
@kubevirt-bot kubevirt-bot merged commit 608031a into kubevirt:main Oct 14, 2024
15 checks passed
@nestoracunablanco nestoracunablanco deleted the feat/s390xPrometheus branch October 15, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants