[release-0.95] tools/bumper: Fix latest vtag check #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the bumper logic, in case either currentReleaseVersion or latestReleaseVersion are in virtual-tag format (i.e. v0.44.1-1-g4cd33665) - then the bump should be initiated. However the logic implementing it is wrong. Fixing logic, adding unit tests. Signed-off-by: Ram Lavi <[email protected]>
kubevirt-bot
force-pushed
the
cherry-pick-1888-to-release-0.95
branch
from
5763f89 to
07a6b9b
Compare
kubevirt-bot
added
the
release-note-none
kubevirt-bot
added
the
dco-signoff: yes
|
/hold |
kubevirt-bot
added
the
do-not-merge/hold
|
/lgtm |
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RamLavi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/hold cancel |
kubevirt-bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #1888
/assign RamLavi