Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP DNM git actions,ipam: Bump packages #1879

Closed
wants to merge 4 commits into from
Closed

Conversation

oshoval
Copy link
Collaborator

@oshoval oshoval commented Sep 8, 2024

What this PR does / why we need it:
Please dont review, trying to debug using this PR.

Special notes for your reviewer:

Release note:

None

@kubevirt-bot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 8, 2024
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from oshoval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oshoval oshoval marked this pull request as ready for review September 8, 2024 08:08
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 8, 2024
@oshoval
Copy link
Collaborator Author

oshoval commented Sep 8, 2024

This might help IPAM, it passed once, where on other PRs it flakes every run lately
in any case those packages are outdated and cause git actions to select different policies (i.e different nodes etc)

rerunning few times

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 8, 2024
@oshoval
Copy link
Collaborator Author

oshoval commented Sep 8, 2024

it didnt help
https://github.com/kubevirt/cluster-network-addons-operator/actions/runs/10758067363/job/29833431320?pr=1879

lets remove KMP from the git action lane, to see if it is resources related

next step is to fix the artifacts collector, as it will hint what happens

Lets free some resources, as the nodes of git actions
doesn't have many.

Signed-off-by: Or Shoval <[email protected]>
@oshoval oshoval changed the title git actions,ipam: Bump packages WIP git actions,ipam: Bump packages Sep 8, 2024
@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M and removed size/XS labels Sep 8, 2024
@oshoval oshoval changed the title WIP git actions,ipam: Bump packages WIP DNM git actions,ipam: Bump packages Sep 8, 2024
@oshoval
Copy link
Collaborator Author

oshoval commented Sep 8, 2024

This is weird (unless it is not related to the config below)
https://github.com/kubevirt/cluster-network-addons-operator/actions/runs/10758730777/job/29834484093?pr=1879
it deploys kubevirt 1.3.1

but we still have
testns-27793141b virt-launcher-alpine-641c9b07e-h7wq4 2/3 Error 0 5m
due to guest-console-log container, even that
we are using
kubectl -n kubevirt patch kubevirt kubevirt --type=merge --patch '{"spec":{"configuration":{"virtualMachineOptions":{"disableSerialConsoleLog":{}}}}}'

@akalenyu
can you suggest please ?
should i try latest nighly kubevirt instead ? (but not sure something was fixed after stable kubevirt release 1.3.1
wrt guest-console-log)
EDIT - seems 1.3 does have the logic to bypass it basically

checking if we are using (seems we dont)

	if vmi.Spec.Domain.Devices.LogSerialConsole != nil {
		return *vmi.Spec.Domain.Devices.LogSerialConsole
	}

as it bypass the flag

EDIT ah NVM, we need to add it when using CNAO as well to the CR
sorry for the noise

@oshoval oshoval marked this pull request as draft September 8, 2024 10:11
Copy link

sonarqubecloud bot commented Sep 8, 2024

@oshoval
Copy link
Collaborator Author

oshoval commented Sep 8, 2024

created #1882

@oshoval oshoval closed this Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants