[MTV-595] Refactor run virt-customize for linux on any non windows #998
Conversation
Signed-off-by: yaacov <[email protected]>
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #998 +/- ##
==========================================
- Coverage 16.50% 16.46% -0.05%
==========================================
Files 107 107
Lines 19628 19628
==========================================
- Hits 3240 3231 -9
- Misses 16099 16110 +11
+ Partials 289 287 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| // RHEL | ||
| if strings.Contains(operatingSystem, "rhel") { | ||
| // Linux | ||
| if !strings.Contains(operatingSystem, "win") { |
There was a problem hiding this comment.
Could we actually check for the family == 'linux' here.
osinfo-db has family, see: https://gitlab.com/libosinfo/osinfo-db/-/blob/main/data/os/fedoraproject.org/fedora-38.xml.in?ref_type=heads#L
There was a problem hiding this comment.
… with that approach we don't risk to be run on i.e. freebsd
There was a problem hiding this comment.
we use the xml output of virt-v2v, this information is missing, IMHO it's safe to try and run on any machine that is not identifying as windows, the script test for udev script and will not override if exist, and will fail gracefully if it can't find the network manager configuration scripts.
Backport of #985 - sen mac <=> ip mappings for linux #983 - customize script for linux #997 - refactor bash script #998 - run customize script on any linux Ref: https://issues.redhat.com/browse/MTV-595 Issue: When migrating a simple RHEL8 VM from VMware 7 to OCPv 4.13 the name of the network interfaces changes and the static IP configuration for the VM no longer works --------- Signed-off-by: yaacov <[email protected]>
Ref: https://issues.redhat.com/browse/MTV-595
Issue:
The original issue was reported on RHEL8, after discussions with reporter we found out that this fix may be helpful for other distributions.
Concerns:
The fix will work for machines that use network manager, but will no nothing in other cases.