Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s.md #993

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Update k8s.md #993

merged 1 commit into from
Aug 26, 2024

Conversation

cniket
Copy link
Contributor

@cniket cniket commented Aug 26, 2024

For installing forklift, kubectl apply command is provided. The https url in that command is incorrect, it is pointing to old /konveyor/forklift-operator/... repo. This PR is to modify that url to point to new artifacts from /kubev2v/forklift/.. repo.
Users directly use the kubectl command and then the artifacts from the old archived repo gets installed.

@cniket cniket requested review from mnecas and yaacov as code owners August 26, 2024 05:23
@yaacov
Copy link
Member

yaacov commented Aug 26, 2024

@cniket hi, welcome to the contributor 🎉

we ask contributor to sign there commits, ( DCO ) do you need help signing the commit ?

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.25%. Comparing base (ef4b47d) to head (97acbe7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #993      +/-   ##
==========================================
+ Coverage   16.21%   16.25%   +0.04%     
==========================================
  Files         106      106              
  Lines       19548    19548              
==========================================
+ Hits         3169     3178       +9     
+ Misses      16099    16088      -11     
- Partials      280      282       +2     
Flag Coverage Δ
unittests 16.25% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

For installing forklift, `kubectl apply` command is provided. The https url in that command is incorrect, it is pointing to old /konveyor/forklift-operator/... repo.
This PR is to modify that url to point to new artifacts from /kubev2v/forklift/.. repo.
Users directly use the `kubectl` command and then the artifacts from the old archived repo gets installed.

Signed-off-by: Niket Chavan <[email protected]>
Copy link

@cniket
Copy link
Contributor Author

cniket commented Aug 26, 2024

@cniket hi, welcome to the contributor 🎉

we ask contributor to sign there commits, ( DCO ) do you need help signing the commit ?

Hello @yaacov , Thank you!
I have added the sign off.

Thanks.

@yaacov
Copy link
Member

yaacov commented Aug 26, 2024

@mnecas PTAL

@yaacov yaacov merged commit d2e174a into kubev2v:main Aug 26, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants