Support LUKS keys for cold migrations from vSphere (backport) #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds the LUKS keys to the VM specs using a secret ref. It expected to have list of strings. Each value will use the `all` selector option based on virt-v2v docs (https://www.libguestfs.org/virt-v2v.1.html). The secret should be provided in the destination namespace, the key should be `luks` and the values should be the arguments provided to virt-v2v, such as: ``` passphrase1 passphrase2 ... ``` Signed-off-by: Liran Rotenberg <[email protected]>
This patch will set the expected LUKS secret to virt-v2v pod as a volume mounted to the virt-v2v container. This will later allow us to read the secret and provide the arguments to the migration. Signed-off-by: Liran Rotenberg <[email protected]>
This patch will read the given LUKS key provided to the container and add them as arguments to the virt-v2v command. Since virt-v2v supports this feature only since 2.2, it applies only for cold migrations. It uses the `all` selector to each passphrase. Signed-off-by: Liran Rotenberg <[email protected]>
When importing from vSphere or OVA and using EL8 virt-v2v (warm migration), LUKS encryption is not supported. In case the plan is set with LUKS secret, fail to validate such plan. Signed-off-by: Liran Rotenberg <[email protected]>
Instead of the plan keep being running and the conversion pod try to init, we can query and check the secret existence for LUKS keys before. In the case it's doesn't exist, fail the migration properly. If it does exist, post it on the target namespace for the conversion pod. Signed-off-by: Liran Rotenberg <[email protected]>
Signed-off-by: Arik Hadas <[email protected]>
Signed-off-by: Arik Hadas <[email protected]>
|
ahadas
approved these changes
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add LUKS key to the vm
This patch adds the LUKS keys to the VM specs using a secret ref. It
expected to have list of strings. Each value will use the
allselectoroption based on virt-v2v docs
(https://www.libguestfs.org/virt-v2v.1.html).
The secret should be provided in the destination namespace, the key
should be
luksand the values should be the arguments provided tovirt-v2v, such as:
Backport of #676