Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't cleanup forklift entities on remote cluster (backport) #875

Merged
merged 1 commit into from
May 1, 2024

Conversation

liranr23
Copy link
Member

@liranr23 liranr23 commented May 1, 2024

When MTV is not installed on the remote OCP cluster and we try to cleanup we won't succeed. This patch won't try to remove or edit forklift entities, as if MTV doesn't exist there, it will fail - causing the plan to fail.

Backport of #865

When MTV is not installed on the remote OCP cluster and we try to
cleanup we won't succeed. This patch won't try to remove or edit
forklift entities, as if MTV doesn't exist there, it will fail - causing
the plan to fail.

Signed-off-by: Liran Rotenberg <[email protected]>
Copy link

sonarqubecloud bot commented May 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ahadas ahadas merged commit 65595ad into kubev2v:release-v2.6.1 May 1, 2024
6 checks passed
@liranr23 liranr23 deleted the dont_clean_remote branch May 1, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants