vSphere: URL in the secret is optional #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users should specify the URL in the secret in case they like the system to validate the provider configuration using a webhook (additional labels are also required on the secret in this case). But when users ar not interested in such validations, they can omit the URL from the secret and the migration from a valid provider should succeed. However, recent changes in the builder of vSphere caused the URL we pass to virt-v2v to be taken from the secret and thus virt-v2v was provided with an empty URL in the aforementioned case, causing the migration to fail. Here, we replace that part and rather take the URL from the configuration of the provider (instead of its secret). Signed-off-by: Arik Hadas <[email protected]>
|
liranr23
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users should specify the URL in the secret in case they like the system to validate the provider configuration using a webhook (additional labels are also required on the secret in this case). But when users ar not interested in such validations, they can omit the URL from the secret and the migration from a valid provider should succeed.
However, recent changes in the builder of vSphere caused the URL we pass to virt-v2v to be taken from the secret and thus virt-v2v was provided with an empty URL in the aforementioned case, causing the migration to fail. Here, we replace that part and rather take the URL from the configuration of the provider (instead of its secret).