OVA: generate random names for NFS pv and PVS used for migration #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bella Khizgiyaev <[email protected]>
Signed-off-by: Bella Khizgiyaev <[email protected]>
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #757 +/- ##
=========================================
+ Coverage 0 16.92% +16.92%
=========================================
Files 0 88 +88
Lines 0 17877 +17877
=========================================
+ Hits 0 3025 +3025
- Misses 0 14607 +14607
- Partials 0 245 +245
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bennyz
reviewed
Feb 21, 2024
| Name: pvcName, | ||
| Namespace: r.Plan.Spec.TargetNamespace, | ||
| Labels: labels, | ||
| GenerateName: pvcNamePrefix, |
There was a problem hiding this comment.
you can call getEntityPrefixName here directly I think
ahadas
reviewed
Feb 22, 2024
bkhizgiy
changed the title
Signed-off-by: Bella Khizgiyaev <[email protected]>
ahadas
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue has been identified where manually constructed names for PVCs lead to migration failures, especially during restarts or when reusing the same plan names. This occurs because of conflicts with existing PVCs. To address this, the implementation now utilizes
GeneratedNameto ensure unique naming and prevent collisions. Correspondingly, the cleanup process has been changed to accommodate these changes.