Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix linter issues #754

Merged
merged 1 commit into from
Feb 22, 2024
Merged

fix linter issues #754

merged 1 commit into from
Feb 22, 2024

Conversation

bennyz
Copy link
Member

@bennyz bennyz commented Feb 19, 2024

No description provided.

@bennyz bennyz force-pushed the linter branch 3 times, most recently from afa69b5 to 6cb087a Compare February 19, 2024 10:44
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 43 lines in your changes are missing coverage. Please review.

Comparison is base (a55e08e) 0.00% compared to head (3f80980) 16.85%.
Report is 210 commits behind head on main.

Files Patch % Lines
...controller/provider/container/vsphere/collector.go 0.00% 6 Missing ⚠️
pkg/controller/provider/web/vsphere/client.go 0.00% 6 Missing ⚠️
pkg/controller/plan/controller.go 0.00% 5 Missing ⚠️
pkg/controller/provider/web/vsphere/tree.go 0.00% 4 Missing ⚠️
pkg/lib/inventory/model/table.go 55.55% 3 Missing and 1 partial ⚠️
pkg/controller/plan/adapter/openstack/builder.go 0.00% 3 Missing ⚠️
pkg/controller/plan/predicate.go 0.00% 3 Missing ⚠️
pkg/lib/inventory/model/journal.go 0.00% 2 Missing and 1 partial ⚠️
pkg/controller/plan/adapter/openstack/client.go 0.00% 1 Missing ⚠️
pkg/controller/plan/adapter/ova/builder.go 0.00% 1 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff            @@
##           main     #754       +/-   ##
=========================================
+ Coverage      0   16.85%   +16.85%     
=========================================
  Files         0       88       +88     
  Lines         0    17882    +17882     
=========================================
+ Hits          0     3014     +3014     
- Misses        0    14625    +14625     
- Partials      0      243      +243     
Flag Coverage Δ
unittests 16.85% <20.37%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/lib/filebacked/list_test.go Show resolved Hide resolved
tests/suit/utils/pod.go Outdated Show resolved Hide resolved
@bennyz bennyz force-pushed the linter branch 5 times, most recently from bf0f49f to d6108dc Compare February 19, 2024 16:15
pkg/controller/host/handler/vsphere/handler.go Outdated Show resolved Hide resolved
pkg/controller/map/storage/handler/ova/handler.go Outdated Show resolved Hide resolved
pkg/controller/provider/container/ovirt/collector.go Outdated Show resolved Hide resolved
pkg/controller/provider/container/ovirt/collector.go Outdated Show resolved Hide resolved
pkg/controller/provider/web/openstack/tree.go Outdated Show resolved Hide resolved
pkg/controller/provider/web/ovirt/tree.go Outdated Show resolved Hide resolved
pkg/lib/filebacked/list.go Outdated Show resolved Hide resolved
pkg/lib/inventory/model/table.go Outdated Show resolved Hide resolved
tests/suit/utils/pod.go Show resolved Hide resolved
@bennyz bennyz force-pushed the linter branch 2 times, most recently from 944049b to 54eee16 Compare February 22, 2024 09:23
Copy link
Member

@ahadas ahadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on the one hand, it's pretty late in the development cycle of 2.6 but, on the other hand, if we wait with this until we branch out, it may make backports more complex - so let's get it in to the main branch before we branch out 2.6

Signed-off-by: Benny Zlotnik <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

Issues
5 New issues

Measures
0 Security Hotspots
No data about Coverage
7.4% Duplication on New Code

See analysis details on SonarCloud

@ahadas ahadas merged commit dd89fcb into kubev2v:main Feb 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants