Change virt-v2v bash script to use go wrapper

[bkhizgiy]

This PR updates the virt-v2v image, replacing the existing bash script with a Go wrapper. This enhancement simplifies control over code changes.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a55e08e) 0.00% compared to head (e8b2990) 17.09%.
Report is 194 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##           main     #746       +/-   ##
=========================================
+ Coverage      0   17.09%   +17.09%     
=========================================
  Files         0       87       +87     
  Lines         0    17819    +17819     
=========================================
+ Hits          0     3047     +3047     
- Misses        0    14529    +14529     
- Partials      0      243      +243     

Flag	Coverage Δ
unittests	17.09% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ahadas]

looks good, minor comments

[bkhizgiy]

After adding modification the correct command is executed now but it still taking long time (almost an hour) triggered the same conversion with the original image for time and output comparison.

[bkhizgiy]

After adding modification the correct command is executed now but it still taking long time (almost an hour) triggered the same conversion with the original image for time and output comparison.

The issue is with the monitor code, it wasn't running properly, so both the conversion + copy disks steps were count under the conversion (and the time adds up similarly to the original code two steps), triggered another conversion to see if the monitor running correctly after the changes.

[ahadas]

The issue is with the monitor code, it wasn't running properly, so both the conversion + copy disks steps were count under the conversion (and the time adds up similarly to the original code two steps)

I think that I saw it once when I played with the VDDK validation - it doesn't seem to be a result of your changes
but that wouldn't explain the relatively long time, @bkhizgiy did you see that VDDK is now specified correctly?

[bkhizgiy]

The issue is with the monitor code, it wasn't running properly, so both the conversion + copy disks steps were count under the conversion (and the time adds up similarly to the original code two steps)

I think that I saw it once when I played with the VDDK validation - it doesn't seem to be a result of your changes but that wouldn't explain the relatively long time, @bkhizgiy did you see that VDDK is now specified correctly?

Yes I see the command is set correctly now, and i also compered the outputs with my changes and the original script and it the same. Its just not running the monitor part correctly.

For the original script the conversion took 15 min and disk copy 43 min.
For my changes the conversion took 55 min and the copy none, so i just think its not recognize correctly when to move on to the next step.

[liranr23]

The issue is with the monitor code, it wasn't running properly, so both the conversion + copy disks steps were count under the conversion (and the time adds up similarly to the original code two steps)

I think that I saw it once when I played with the VDDK validation - it doesn't seem to be a result of your changes but that wouldn't explain the relatively long time, @bkhizgiy did you see that VDDK is now specified correctly?

Yes I see the command is set correctly now, and i also compered the outputs with my changes and the original script and it the same. Its just not running the monitor part correctly.

For the original script the conversion took 15 min and disk copy 43 min. For my changes the conversion took 55 min and the copy none, so i just think its not recognize correctly when to move on to the next step.

that might be because the last update of the patch (breaking the two commands apart)
previously it was made as virt-v2v ... |& monitor, so the the pipeline connected the output of virt-v2v to the monitor command input.
now it looks like it first executing virt-v2v and wait for it to finish, then it runs the monitor command

[bkhizgiy]

Fixed the monitor consuming issue, now the conversion phase work properly.

[bkhizgiy]

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[ahadas]

passes CI, validated locally - merging
and let's follow up with the fix for OVA which was the motivation for these changes