Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'app' label to the template of the migrated VM #671

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

ahadas
Copy link
Member

@ahadas ahadas commented Dec 6, 2023

This label is used for identification of the virtual machine instance(s)
that will be created from the VM, for example for load balancing, see:

https://github.com/rhpds/roadshow_ocpvirt_instructions/blob/d3b008cb5d7855b54ab912dda9f8d174dd93dcbc/workshop/content/08_migrate_vms.adoc#review-and-configure-migrated-virtual-machines

Signed-off-by: Arik Hadas <[email protected]>
@ahadas ahadas requested review from liranr23 and bkhizgiy December 6, 2023 10:25
Copy link

sonarcloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ahadas ahadas merged commit 667a378 into kubev2v:main Dec 6, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants