OVA: Fix phases display for OVA provider creation #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkhizgiy
commented
Dec 5, 2023
liranr23
reviewed
Dec 5, 2023
@bkhizgiy I've rephrased the description a bit - did you mean "displayed" here? |
ahadas
reviewed
Dec 10, 2023
bkhizgiy
commented
Dec 12, 2023
bkhizgiy
commented
Dec 12, 2023
bkhizgiy
force-pushed
the
reconcile
branch
4 times, most recently
from
a6874ad to
4943080
Compare
ahadas
reviewed
Dec 24, 2023
ahadas
reviewed
Dec 24, 2023
ahadas
reviewed
Dec 24, 2023
bkhizgiy
changed the title
Signed-off-by: Bella Khizgiyaev <[email protected]>
Signed-off-by: Bella Khizgiyaev <[email protected]>
Signed-off-by: Bella Khizgiyaev <[email protected]>
Signed-off-by: Bella Khizgiyaev <[email protected]>
Signed-off-by: Bella Khizgiyaev <[email protected]>
bkhizgiy
commented
Dec 25, 2023
bkhizgiy
changed the title
Signed-off-by: Bella Khizgiyaev <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the OVA provider pod is being created, the pod status currently displays
connectionFaileduntil the OVA pod is actually up and running, this gives the wrong impression that something went wrong during the OVA provider creation. This fix changes the phases for the OVA provider. Once the provider is added, the status will immediately showstaging. If there is a failure during the OVA provider creation process, or if the pod is not running after 10 minutes (consider as a timeout), the status will change toconnectionFailed.