Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ovirt: Reconcile disk on USER_UPDATE_VM_DISK #648

Merged
merged 2 commits into from
Nov 12, 2023

Conversation

ahadas
Copy link
Member

@ahadas ahadas commented Nov 12, 2023

When a disk is extended in RHV, the size is not updated in the inventory causing the VM to be imported with old disk size. This is now solved by reconciling the disk on USER_UPDATE_VM_DISK.

https://issues.redhat.com/browse/MTV-830

Backport of #646

nijinashok and others added 2 commits November 12, 2023 15:19
When a disk is extended in RHV, the size was not updated in the inventory
causing the VM to be imported with old disk size. This is now solved
by reconciling the disk on USER_UPDATE_VM_DISK.

Signed-off-by: Nijin Ashok <[email protected]>
The VM-specific properties (e.g., disk interface) are handled by
VMAdapter. The handling by DiskAdapter of USER_UPDATE_VM_DISK events is
for updating the disk properties that are not VM-specific, this moving
this event to the section of disk-events (minor change).

Signed-off-by: Arik Hadas <[email protected]>
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ahadas ahadas merged commit 5e5e4f8 into kubev2v:release-v2.5.3 Nov 12, 2023
7 checks passed
@ahadas ahadas deleted the release-v2.5.3 branch November 12, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants