Make the filesystem overhead configurable #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranr23
requested review from
ahadas,
bennyz,
mmartinv and
mnecas
as code owners
liranr23
force-pushed
the
fs_overhead
branch
from
0afd260 to
c6ffd50
Compare
liranr23
commented
Nov 12, 2023
operator/roles/forkliftcontroller/templates/controller/deployment-controller.yml.j2
Outdated
Show resolved
Hide resolved
bennyz
approved these changes
Nov 12, 2023
ahadas
reviewed
Nov 12, 2023
This patch will allow the user to configure the filesystem overhead. Currently it defaults to 10%. The overhead is mainly required for ext4 and the root partition. Signed-off-by: Liran Rotenberg <[email protected]>
liranr23
force-pushed
the
fs_overhead
branch
from
c6ffd50 to
1c196bc
Compare
Signed-off-by: Liran Rotenberg <[email protected]>
When having an error due wrong configuration of the controller, return the error. Signed-off-by: Liran Rotenberg <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
ahadas
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch will allow the user to configure the filesystem overhead. Currently it defaults to 10%. The overhead is mainly required for ext4 and the root partition.
https://issues.redhat.com/browse/MTV-545