Keep the populator pod on failure #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranr23
commented
Oct 31, 2023
This patch will keep the populator pod existence when failing. It won't restart or recreated. This is in the mind of aligning with v2v pod failure and the thought that once we fail, we will most likely keep failing. This change will allow to get the populator logs in case of failure in a easy way. Signed-off-by: Liran Rotenberg <[email protected]>
liranr23
force-pushed
the
populator_logs
branch
from
7828ad1 to
20d68b7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Signed-off-by: Liran Rotenberg <[email protected]>
ahadas
reviewed
Nov 1, 2023
Signed-off-by: Liran Rotenberg <[email protected]>
liranr23
force-pushed
the
populator_logs
branch
from
f7211d5 to
92195e1
Compare
ahadas
reviewed
Nov 7, 2023
liranr23
force-pushed
the
populator_logs
branch
4 times, most recently
from
a2ae56e to
2d35602
Compare
liranr23
force-pushed
the
populator_logs
branch
from
2d35602 to
96c7491
Compare
ahadas
reviewed
Nov 12, 2023
liranr23
force-pushed
the
populator_logs
branch
2 times, most recently
from
1565451 to
d2b06af
Compare
liranr23
force-pushed
the
populator_logs
branch
from
d2b06af to
c677f4f
Compare
This change will count the number of restarts for the populator pod on the destination PVC. That allows us to limit the number of recreations of the pod. After 3 attempts, it will stop recreating it. Signed-off-by: Liran Rotenberg <[email protected]>
liranr23
force-pushed
the
populator_logs
branch
from
c677f4f to
51d4ce3
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
ahadas
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch will keep the populator pod existence when failing. It won't restart or recreated. This is in the mind of aligning with v2v pod failure and the thought that once we fail, we will most likely keep failing. This change will allow to get the populator logs in case of failure in a easy way.