Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e test for ova provider #630

Merged
merged 5 commits into from
Dec 5, 2023
Merged

Add e2e test for ova provider #630

merged 5 commits into from
Dec 5, 2023

Conversation

bkhizgiy
Copy link
Member

@bkhizgiy bkhizgiy commented Oct 18, 2023 •
edited by ahadas
Loading

liranr23
liranr23 reviewed Oct 18, 2023
View reviewed changes
tests/suit/utils/storagemap.go Outdated Show resolved Hide resolved
tests/suit/framework/framework.go Show resolved Hide resolved
tests/suit/framework/framework.go Outdated Show resolved Hide resolved
tests/suit/framework/ova.go Outdated Show resolved Hide resolved
tests/suit/framework/ova.go Outdated Show resolved Hide resolved
ahadas
ahadas reviewed Oct 22, 2023
View reviewed changes
tests/suit/framework/framework.go Outdated Show resolved Hide resolved
tests/suit/framework/ova.go Show resolved Hide resolved
tests/suit/framework/ova.go Outdated Show resolved Hide resolved
tests/suit/ova_test.go Outdated Show resolved Hide resolved
tests/suit/utils/storagemap.go Outdated Show resolved Hide resolved
@ahadas ahadas added this to the 2.6.0 milestone Oct 26, 2023
@ahadas
Copy link
Member

ahadas commented Oct 29, 2023

@bkhizgiy I've merged the PR for forkliftci, note that there's a new version of forkliftci, v9.0, that includes the OVA. need to bump the version we use here

@ahadas ahadas removed this from the 2.6.0 milestone Nov 5, 2023
@bkhizgiy
Copy link
Member Author

bkhizgiy commented Nov 7, 2023

Still missing two CI changes.

  • need to change the vm.ova file used, the current one don't have proper network config for the test.
  • need to understand how to use virt-v2v real image (and not stub) for ALL endpoint in the CI.

@bkhizgiy
Copy link
Member Author

Need to merge PR #643 for the tests to pass.

@bkhizgiy
Copy link
Member Author

Missing kubev2v/forkliftci#114 for pulling images.

@bkhizgiy bkhizgiy mentioned this pull request Nov 26, 2023
Closed
@bkhizgiy bkhizgiy force-pushed the ci branch 11 times, most recently from 0ec0a4d to 2d09dab Compare December 3, 2023 21:59
ahadas
ahadas reviewed Dec 4, 2023
View reviewed changes
.github/workflows/pull-request.yml Outdated Show resolved Hide resolved
pkg/settings/migration.go Outdated Show resolved Hide resolved
tests/suit/utils/storagemap.go Show resolved Hide resolved
tests/suit/framework/ova.go Outdated Show resolved Hide resolved
tests/suit/ova_test.go Show resolved Hide resolved
tests/suit/framework/ova.go Show resolved Hide resolved
tests/suit/framework/ova.go Outdated Show resolved Hide resolved
@bkhizgiy bkhizgiy force-pushed the ci branch 3 times, most recently from 3d880fa to 8833447 Compare December 4, 2023 16:15
@ahadas
minor cleanup
33d81bc 
Signed-off-by: Arik Hadas <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

@ahadas ahadas merged commit f22a649 into kubev2v:main Dec 5, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liranr23 liranr23 liranr23 left review comments

@ahadas ahadas ahadas approved these changes

@eslutsky eslutsky Awaiting requested review from eslutsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkhizgiy @ahadas @liranr23