Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump images dependencies #616

Closed
wants to merge 4 commits into from
Closed

Bump images dependencies #616

wants to merge 4 commits into from

Conversation

liranr23
Copy link
Member

@liranr23 liranr23 commented Oct 3, 2023

No description provided.

ahadas
ahadas reviewed Oct 3, 2023
View reviewed changes
Copy link
Member

@ahadas ahadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to separate out the changes of virt-v2v dependencies to a separate PR as it's just about running a script so it can get it quickly

.github/workflows/pull-request.yml Outdated Show resolved Hide resolved
WORKSPACE Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember that @bennyz suggested to drop few dependencies that are not used, did you check whether all those dependencies that are updated here are actually used? it's a good opportunity for a cleanup

hack/ova-provider-server/Containerfile Outdated Show resolved Hide resolved
hack/ovirt-populator/Containerfile Outdated Show resolved Hide resolved
@liranr23
bump bazel and images releases
97e7ba7 
Signed-off-by: Liran Rotenberg <[email protected]>
ahadas
ahadas approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@ahadas ahadas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes looks good, we can filter out unused dependencies as a follow-up

@liranr23 liranr23 force-pushed the bump_builds branch 2 times, most recently from aba64a1 to 83588e1 Compare October 4, 2023 12:37
@liranr23
change ansible k8s dep
2439d9d 
Signed-off-by: Liran Rotenberg <[email protected]>
@liranr23
futher changes
3543c5e 
Signed-off-by: Liran Rotenberg <[email protected]>
@liranr23
add layer to the operator image
facdec6 
Signed-off-by: Liran Rotenberg <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Oct 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 13453 Code Smells

No Coverage information No Coverage information
0.8% 0.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@ahadas ahadas modified the milestone: 2.6.0 Oct 15, 2023
@liranr23 liranr23 closed this Jan 11, 2024
@liranr23 liranr23 deleted the bump_builds branch January 11, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahadas ahadas ahadas approved these changes

@mnecas mnecas Awaiting requested review from mnecas mnecas will be requested when the pull request is marked ready for review mnecas is a code owner

@yaacov yaacov Awaiting requested review from yaacov yaacov will be requested when the pull request is marked ready for review yaacov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liranr23 @ahadas