Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump ovirt-imageio and virt-v2v dependencies #615

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Conversation

bkhizgiy
Copy link
Member

@bkhizgiy bkhizgiy commented Oct 3, 2023

No description provided.

@bkhizgiy bkhizgiy requested a review from ahadas as a code owner October 3, 2023 11:06
@bkhizgiy bkhizgiy changed the title bump kernal dependencies bump kernel dependencies Oct 3, 2023
Copy link
Member

@ahadas ahadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but please change the title - it's not about "kernel dependencies" but "ovirt-imageio dependencies"

@bkhizgiy bkhizgiy changed the title bump kernel dependencies bump ovirt-imageio dependencies Oct 3, 2023
@ahadas
Copy link
Member

ahadas commented Oct 3, 2023

@bkhizgiy please change the title of the commit message as well (not only the title of the PR)

@bkhizgiy bkhizgiy requested a review from nyoxi as a code owner October 3, 2023 11:43
@bkhizgiy bkhizgiy changed the title bump ovirt-imageio dependencies bump ovirt-imageio and virt-v2v dependencies Oct 3, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ahadas ahadas merged commit 658d34b into kubev2v:main Oct 3, 2023
8 checks passed
@ahadas ahadas mentioned this pull request Oct 3, 2023
@@ -100,21 +102,23 @@ rpmtree(
"@glibc-common-0__2.34-82.el9.x86_64//rpm",
"@glibc-devel-0__2.34-82.el9.x86_64//rpm",
"@glibc-headers-0__2.34-82.el9.x86_64//rpm",
"@glibc-langpack-tl-0__2.34-82.el9.x86_64//rpm",
"@glibc-langpack-pt-0__2.34-82.el9.x86_64//rpm",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bazeldnf is needlessly switching between package alternatives, same for example for libcurl below. See here for how this was solved for virt-v2v images: https://github.com/kubev2v/forklift/blob/main/hack/virt-v2v-cold-rpm-deps.sh#L28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants