Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocp: consider missing namespace in network name #610

Closed
wants to merge 1 commit into from
Closed

ocp: consider missing namespace in network name #610

wants to merge 1 commit into from

Conversation

bennyz
Copy link
Member

@bennyz bennyz commented Sep 28, 2023

backport posted #608

@bennyz
ocp: consider missing namespace in network name
f6872d5 
The namespace may be missing from the network name, in this case we need
to use the VM's namespace

Also contains:

ocp: extract to function and add unit test

Signed-off-by: Benny Zlotnik <[email protected]>
@bennyz bennyz requested a review from ahadas as a code owner September 28, 2023 10:47
@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bennyz bennyz closed this Sep 28, 2023
@bennyz bennyz deleted the backport-ocp-network branch September 28, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahadas ahadas Awaiting requested review from ahadas ahadas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bennyz