Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocp: fix network lookup #605

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

bennyz
Copy link
Member

@bennyz bennyz commented Sep 27, 2023

name and namespace were in an incorrect order

@bennyz bennyz requested a review from ahadas as a code owner September 27, 2023 13:45
Copy link
Member

@ahadas ahadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question and please remove the debug logs

pkg/controller/plan/adapter/ocp/validator.go Show resolved Hide resolved
name and namespace were in an incorrect order

Signed-off-by: Benny Zlotnik <[email protected]>
@bennyz bennyz force-pushed the fix-network-mapping-lookup branch from d68fcdd to 0660ad6 Compare September 27, 2023 15:55
@sonarcloud
Copy link

sonarcloud bot commented Sep 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.0% 5.0% Duplication

@ahadas
Copy link
Member

ahadas commented Sep 27, 2023

@bennyz please backport

@ahadas ahadas merged commit 79fc21a into kubev2v:main Sep 27, 2023
5 of 7 checks passed
@bennyz bennyz deleted the fix-network-mapping-lookup branch September 27, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants