ocp: consider missing namespace in network name #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahadas
approved these changes
Sep 18, 2023
ahadas
force-pushed
the
ocp-network-fix
branch
from
22b9c88 to
f792230
Compare
ahadas
reviewed
Sep 18, 2023
The namespace may be missing from the network name, in this case we need to use the VM's namespace Signed-off-by: Benny Zlotnik <[email protected]>
bennyz
force-pushed
the
ocp-network-fix
branch
from
f792230 to
5e30067
Compare
Signed-off-by: Benny Zlotnik <[email protected]>
bennyz
force-pushed
the
ocp-network-fix
branch
from
5e30067 to
1171069
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
ahadas
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The namespace may be missing from the network name, in this case we need to use the VM's namespace