openstack: fix cognitive complexity #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmartinv
force-pushed
the
openstack-fix-congnitive-complexity
branch
from
5986718 to
616391a
Compare
ahadas
reviewed
Aug 3, 2023
mmartinv
force-pushed
the
openstack-fix-congnitive-complexity
branch
2 times, most recently
from
b630f54 to
39586bb
Compare
mmartinv
force-pushed
the
openstack-fix-congnitive-complexity
branch
from
c455d42 to
0d7926c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
ahadas
force-pushed
the
openstack-fix-congnitive-complexity
branch
2 times, most recently
from
004db30 to
09ff44b
Compare
ahadas
reviewed
Dec 25, 2023
ahadas
force-pushed
the
openstack-fix-congnitive-complexity
branch
3 times, most recently
from
f8672cf to
736e698
Compare
ahadas
force-pushed
the
openstack-fix-congnitive-complexity
branch
from
fe1139c to
8c38ac2
Compare
bennyz
reviewed
Dec 25, 2023
Signed-off-by: Miguel Martín <[email protected]>
Signed-off-by: Arik Hadas <[email protected]>
Signed-off-by: Arik Hadas <[email protected]>
ahadas
force-pushed
the
openstack-fix-congnitive-complexity
branch
from
8c38ac2 to
db0d364
Compare
ahadas
force-pushed
the
openstack-fix-congnitive-complexity
branch
2 times, most recently
from
1f56c64 to
ba1e1af
Compare
Signed-off-by: Arik Hadas <[email protected]>
Signed-off-by: Arik Hadas <[email protected]>
ahadas
force-pushed
the
openstack-fix-congnitive-complexity
branch
from
ba1e1af to
c1e99f7
Compare
|
looks ok, you can instead check the storage class (or profile) and see if it's wait for consumer. |
liranr23
approved these changes
Dec 25, 2023
bennyz
approved these changes
Dec 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Miguel Martín [email protected]