MTV-1775 | Fix not finished task NPE #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: If the snapshot creation task did not finish the controller fails with NPE. This happens due to the taks not returning the result and we are trying to typcase that result (nil) to the ManagedObject. Fix: Add check if the task finished or retry. Signed-off-by: Martin Necas <[email protected]>
|
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1273 +/- ##
==========================================
- Coverage 15.48% 15.44% -0.05%
==========================================
Files 112 112
Lines 23388 23399 +11
==========================================
- Hits 3621 3613 -8
- Misses 19479 19501 +22
+ Partials 288 285 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
If the snapshot creation task did not finish the controller fails with NPE. This happens due to the taks not returning the result and we are trying to typcase that result (nil) to the ManagedObject.
Fix:
Add check if the task finished or retry.