Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTV-1632 | Enable SMM for the uefi secureboot #1269

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

mnecas
Copy link
Member

@mnecas mnecas commented Dec 13, 2024

Issue: When the VM has a secureboot the migration fails due to missing SSM

Fix: Enable the SMM for UEFI secureboot
https://kubevirt.io/user-guide/compute/virtual_hardware/

Ref: https://issues.redhat.com/browse/MTV-1632

@mnecas mnecas requested a review from yaacov as a code owner December 13, 2024 16:16
@mnecas mnecas added this to the 2.7.7 milestone Dec 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 15.49%. Comparing base (3929eaf) to head (1c34808).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/plan/adapter/vsphere/builder.go 0.00% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1269      +/-   ##
==========================================
- Coverage   15.53%   15.49%   -0.04%     
==========================================
  Files         112      112              
  Lines       23262    23388     +126     
==========================================
+ Hits         3613     3624      +11     
- Misses      19364    19477     +113     
- Partials      285      287       +2     
Flag Coverage Δ
unittests 15.49% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Dec 13, 2024

@mnecas mnecas merged commit 6aa0f99 into kubev2v:main Dec 13, 2024
16 checks passed
@mnecas mnecas mentioned this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants