Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change make install target to use the right directory name #1208

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

arturshadnik
Copy link
Contributor

make install was broken because the directory name had an s at the end.

Copy link
Member

@yaacov yaacov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.65%. Comparing base (371e0a0) to head (bf7e667).
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1208      +/-   ##
==========================================
- Coverage   15.69%   15.65%   -0.04%     
==========================================
  Files         112      112              
  Lines       23071    23071              
==========================================
- Hits         3620     3612       -8     
- Misses      19163    19174      +11     
+ Partials      288      285       -3     
Flag Coverage Δ
unittests 15.65% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yaacov
Copy link
Member

yaacov commented Nov 26, 2024

/ok-to-test

@mnecas
Copy link
Member

mnecas commented Nov 26, 2024

Thank you for the PR!
LGTM

@mnecas mnecas merged commit 72945ce into kubev2v:main Nov 26, 2024
13 of 15 checks passed
@arturshadnik arturshadnik deleted the fix/make-install branch November 26, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants