Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMware warm migration - Fix snapshot cleanup #1189

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

mnecas
Copy link
Member

@mnecas mnecas commented Nov 15, 2024

Issue:
The CreateSnapshot is after RemovePreviousSnapshot so with the warm migration, we always skipped the snapshot cleanup step.

Fix:
Get the next migration phase dynamically. This way the VMware migration will run RemovePreviousSnapshot and the other migrations will run `CreateSnapshot``.

Ref:
https://issues.redhat.com/browse/MTV-1656

Signed-off-by: Martin Necas <[email protected]>
@mnecas mnecas requested a review from yaacov as a code owner November 15, 2024 14:05
@mnecas mnecas changed the title Fix snapshot cleanup VMware warm migration - Fix snapshot cleanup Nov 15, 2024
@mnecas mnecas added this to the 2.7.4 milestone Nov 15, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 15.65%. Comparing base (71d4376) to head (10089c4).

Files with missing lines Patch % Lines
pkg/controller/plan/migration.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1189   +/-   ##
=======================================
  Coverage   15.65%   15.65%           
=======================================
  Files         112      112           
  Lines       23071    23071           
=======================================
  Hits         3612     3612           
  Misses      19174    19174           
  Partials      285      285           
Flag Coverage Δ
unittests 15.65% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mansam mansam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnecas mnecas merged commit 4ae505e into kubev2v:main Nov 15, 2024
15 of 16 checks passed
This was referenced Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants