Reorder warm migration flow for vSphere VMs #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansam
force-pushed
the
reorder-vsphere-warm-migration
branch
from
2c2d163 to
0bd661a
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1184 +/- ##
==========================================
- Coverage 15.66% 15.66% -0.01%
==========================================
Files 112 112
Lines 23052 23057 +5
==========================================
Hits 3612 3612
- Misses 19155 19160 +5
Partials 285 285
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mnecas
reviewed
Nov 13, 2024
mansam
force-pushed
the
reorder-vsphere-warm-migration
branch
from
cc3ae35 to
4a321d5
Compare
When performing a warm migration of a vSphere VM, the current version of Forklift creates the snapshot for each precopy, gets the change ID for the previous snapshot, and then deletes the previous snapshot. Per the VMware documentation (see MTV-1656), the correct flow is to record the change IDs for the old snapshot, delete it, and then create the new snapshot. This patch implements the correct flow by adding vSphere-specific steps to the warm migration itinerary to ensure that old snapshots are cleaned up and change IDs are recorded before creating new snapshots. Due to the change in flow it's now necessary to store the change IDs somewhere between itinerary phases, so a list of disk/changeid pairs has been added to the Precopy struct. This change requires the CRs to be regenerated. Correcting the warm migration flow appears, at least in some cases, to address the filesystem corruption documented in https://issues.redhat.com/browse/MTV-1656. Signed-off-by: Sam Lucidi <[email protected]>
Signed-off-by: Sam Lucidi <[email protected]>
Signed-off-by: Sam Lucidi <[email protected]>
Signed-off-by: Sam Lucidi <[email protected]>
mansam
force-pushed
the
reorder-vsphere-warm-migration
branch
from
3f3d1a8 to
b10d041
Compare
|
mnecas
approved these changes
Nov 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing a warm migration of a vSphere VM, the current version of Forklift creates the snapshot for each precopy, gets the change ID for the previous snapshot, and then deletes the previous snapshot. Per the VMware documentation, the correct flow is to record the change IDs for the old snapshot, delete it, and then create the new snapshot.
This PR implements the correct flow by adding vSphere-specific steps to the warm migration itinerary to ensure that old snapshots are cleaned up and change IDs are recorded before creating new snapshots. Due to the change in flow it's now necessary to store the change IDs somewhere between itinerary phases, so a list of disk/changeid pairs has been added to the
Precopystruct. This change required the CRs to be regenerated.Correcting the warm migration flow appears, at least in some cases, to address the filesystem corruption documented in https://issues.redhat.com/browse/MTV-1656.
This PR also removes some dead code branches left over from a very old version of Forklift. The
VSphereIncrementalBackupfeature flag is always assumed to be on as this is necessary for the proper warm migration flow, so the alternate code path no longer needs to exist. See https://issues.redhat.com/browse/MTV-1665